array-type: consider this to be simple type (palantir#2982)

HyphnKnight · Apr 9, 2018 · e6e007e · e6e007e
1 parent b7be17b
commit e6e007e
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/src/rules/arrayTypeRule.ts b/src/rules/arrayTypeRule.ts
@@ -145,6 +145,7 @@ function isSimpleType(nodeType: ts.TypeNode): boolean {
         case ts.SyntaxKind.SymbolKeyword:
         case ts.SyntaxKind.VoidKeyword:
         case ts.SyntaxKind.NeverKeyword:
+        case ts.SyntaxKind.ThisType:
             return true;
         case ts.SyntaxKind.TypeReference:
             // TypeReferences must be non-generic or be another Array with a simple type

diff --git a/test/rules/array-type/array-simple/test.ts.fix b/test/rules/array-type/array-simple/test.ts.fix
@@ -17,6 +17,7 @@ interface ArrayClass<T> {
     foo: T[];
     bar: T[];
     baz: Arr<T>;
+    xyz: this[];
 }
 
 function fooFunction(foo: Array<ArrayClass<string>>) {

diff --git a/test/rules/array-type/array-simple/test.ts.lint b/test/rules/array-type/array-simple/test.ts.lint
@@ -27,6 +27,7 @@ interface ArrayClass<T> {
          ~~~~~~~~  [0]
     bar: T[];
     baz: Arr<T>;
+    xyz: this[];
 }
 
 function fooFunction(foo: Array<ArrayClass<string>>) {