Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Fix 2792 this simple type #2982

Merged
merged 2 commits into from
Jul 7, 2017
Merged

Fix 2792 this simple type #2982

merged 2 commits into from
Jul 7, 2017

Conversation

ksvitkovsky
Copy link
Contributor

@ksvitkovsky ksvitkovsky commented Jul 2, 2017

PR checklist

CHANGELOG.md entry:

[bugfix] array-type: consider this to be simple type

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint, @ksvitkovsky! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@ajafff ajafff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Though this may be a breaking change. See #1843 (review)

@adidahiya
Copy link
Contributor

thanks @ksvitkovsky

@adidahiya adidahiya merged commit 8de7cae into palantir:master Jul 7, 2017
@ksvitkovsky ksvitkovsky deleted the fix-2792-this-simple-type branch July 31, 2017 05:54
HyphnKnight pushed a commit to HyphnKnight/tslint that referenced this pull request Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants