Test against Pandas 1.0 #2333
Merged
Test against Pandas 1.0 #2333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
😂 I'm too fast, it's on conda-forge but not PyPI. Will refresh tomorrow... |
alexwlchan
approved these changes
Jan 31, 2020
| @@ -441,7 +441,7 @@ def standard_tox_task(name): | |||
|
|
|||
| for n in [22, 30, 111]: | |||
| standard_tox_task("django%d" % (n,)) | |||
| for n in [19, 20, 21, 22, 23, 24, 25]: | |||
| for n in [19, 20, 21, 22, 23, 24, 25, 100]: | |||
There was a problem hiding this comment.
Not important for this PR, but that’s a long list of supported versions we’re building up – is there a supported versions policy from the pandas team?
There was a problem hiding this comment.
The default policy for the data stack was recently set through the numpy enhancement proposal process - it amounts to supporting Python versions for four years after release, and Numpy (or other foundational libs) for two years after release.
So I'd be fine with dropping several of these as soon as we have reason to, but for now they're far from a bottleneck on our CI (which eg no longer has Python 2 builds!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas 1.0 has just been released, so this PR adds it to our CI.