Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against Pandas 1.0 #2333

Merged
merged 1 commit into from
Jan 31, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ jobs:
TASK: check-pandas24
check-pandas25:
TASK: check-pandas25
check-pandas100:
TASK: check-pandas100
steps:
- task: UsePythonVersion@0
inputs:
Expand Down
7 changes: 7 additions & 0 deletions hypothesis-python/tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,13 @@ deps =
commands =
python -m pytest tests/pandas -n2

[testenv:pandas100]
deps =
-r../requirements/test.txt
pandas~=1.0.0
commands =
python -m pytest tests/pandas -n2


[testenv:django111]
commands =
Expand Down
2 changes: 1 addition & 1 deletion tooling/src/hypothesistooling/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,7 @@ def standard_tox_task(name):

for n in [22, 30, 111]:
standard_tox_task("django%d" % (n,))
for n in [19, 20, 21, 22, 23, 24, 25]:
for n in [19, 20, 21, 22, 23, 24, 25, 100]:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not important for this PR, but that’s a long list of supported versions we’re building up – is there a supported versions policy from the pandas team?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default policy for the data stack was recently set through the numpy enhancement proposal process - it amounts to supporting Python versions for four years after release, and Numpy (or other foundational libs) for two years after release.

So I'd be fine with dropping several of these as soon as we have reason to, but for now they're far from a bottleneck on our CI (which eg no longer has Python 2 builds!)

standard_tox_task("pandas%d" % (n,))

standard_tox_task("coverage")
Expand Down