UID2-2674 implement shared publish to docker versioned #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cYKatherine
force-pushed
the
kcc-UID2-2674-implement-shared-publish-to-docker-versioned
branch
from
3018979
to
cbef5ad
Compare
cYKatherine
force-pushed
the
kcc-UID2-2674-implement-shared-publish-to-docker-versioned
branch
from
5b75ab7
to
8ebca40
Compare
thomasm-ttd
reviewed
Jan 22, 2024
thomasm-ttd
approved these changes
Jan 22, 2024
cYKatherine
force-pushed
the
kcc-UID2-2674-implement-shared-publish-to-docker-versioned
branch
from
6b8c8da
to
7c2a483
Compare
cYKatherine
force-pushed
the
kcc-UID2-2674-implement-shared-publish-to-docker-versioned
branch
from
65418bb
to
0413ebf
Compare
gmsdelmundo
reviewed
Jan 22, 2024
| inputs: | ||
| release_type: | ||
| type: choice | ||
| description: 'The type of release' |
There was a problem hiding this comment.
No need for quotes, and do we need required: true?
There was a problem hiding this comment.
Because it's a type: choice, I don't think we need to add required: true as it's a dropdown menu. I will remove the single quote tho!
| inputs: | ||
| release_type: | ||
| type: choice | ||
| description: 'The type of release' |
There was a problem hiding this comment.
Same comment about quotes, and required: true
thomasm-ttd
approved these changes
Jan 24, 2024
cYKatherine
deleted the
kcc-UID2-2674-implement-shared-publish-to-docker-versioned
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review in order of:
Successful run: