-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UID2-2674 implement shared publish to docker versioned #15
Merged
cYKatherine
merged 9 commits into
main
from
kcc-UID2-2674-implement-shared-publish-to-docker-versioned
Jan 24, 2024
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3261651
Add new workflow
cYKatherine cbef5ad
Use kcc-UID2-2674-implement-shared-publish-to-docker-versioned branch
cYKatherine 8ebca40
Use correct version number
cYKatherine 9692ccc
Rename run-name
cYKatherine 85bf286
Pass in docker_context
cYKatherine 7c2a483
Remove pull_request from the workflow
cYKatherine 0413ebf
Use v2 version
cYKatherine 7ef087c
Remove single quote
cYKatherine 3181c94
Add required: true to release_type
cYKatherine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
name: Release UID2 Examples Image for Server Only | ||
run-name: ${{ inputs.release_type == 'Snapshot' && 'Publish Pre-release' || format('Release {0}', inputs.release_type)}} UID2 Examples Image for Server Only by @${{ github.actor }} | ||
on: | ||
workflow_dispatch: | ||
inputs: | ||
release_type: | ||
type: choice | ||
description: 'The type of release' | ||
options: | ||
- Major | ||
- Minor | ||
- Patch | ||
- Snapshot | ||
|
||
jobs: | ||
incrementVersionNumber: | ||
uses: IABTechLab/uid2-shared-actions/.github/workflows/shared-increase-version-number.yaml@v2 | ||
with: | ||
release_type: ${{ inputs.release_type }} | ||
working_dir: publisher/server_only | ||
secrets: inherit | ||
|
||
publishForServerOnly: | ||
cYKatherine marked this conversation as resolved.
Show resolved
Hide resolved
|
||
uses: IABTechLab/uid2-shared-actions/.github/workflows/shared-publish-to-docker-versioned.yaml@v2 | ||
needs: incrementVersionNumber | ||
with: | ||
new_version: ${{ needs.incrementVersionNumber.outputs.new_version }} | ||
image_tag: ${{ needs.incrementVersionNumber.outputs.image_tag }} | ||
release_type: ${{ inputs.release_type }} | ||
docker_file: publisher/server_only/Dockerfile | ||
docker_context: publisher/server_only | ||
docker_image_name: IABTechLab/uid2-examples | ||
docker_registry: ghcr.io | ||
secrets: inherit |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
name: Release UID2 Examples Image for Standard | ||
run-name: ${{ inputs.release_type == 'Snapshot' && 'Publish Pre-release' || format('Release {0}', inputs.release_type)}} UID2 Examples Image for Standard by @${{ github.actor }} | ||
on: | ||
workflow_dispatch: | ||
inputs: | ||
release_type: | ||
type: choice | ||
description: 'The type of release' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment about quotes, and |
||
options: | ||
- Major | ||
- Minor | ||
- Patch | ||
- Snapshot | ||
|
||
jobs: | ||
incrementVersionNumber: | ||
uses: IABTechLab/uid2-shared-actions/.github/workflows/shared-increase-version-number.yaml@v2 | ||
with: | ||
release_type: ${{ inputs.release_type }} | ||
working_dir: publisher/standard | ||
secrets: inherit | ||
|
||
publishForStandard: | ||
cYKatherine marked this conversation as resolved.
Show resolved
Hide resolved
|
||
uses: IABTechLab/uid2-shared-actions/.github/workflows/shared-publish-to-docker-versioned.yaml@v2 | ||
needs: incrementVersionNumber | ||
with: | ||
new_version: ${{ needs.incrementVersionNumber.outputs.new_version }} | ||
image_tag: ${{ needs.incrementVersionNumber.outputs.image_tag }} | ||
release_type: ${{ inputs.release_type }} | ||
docker_file: publisher/standard/Dockerfile | ||
docker_context: publisher/standard | ||
docker_image_name: IABTechLab/uid2-examples | ||
docker_registry: ghcr.io | ||
secrets: inherit |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{ "$schema": "https://raw.githubusercontent.com/dotnet/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json", "version": "1.0.0", "publicReleaseRefSpec": [ "^refs/heads/master$", "^refs/heads/v\\d+(?:\\.\\d+)?$" ], "cloudBuild": { "setVersionVariables": true, "buildNumber": { "enabled": true, "includeCommitId": { "when": "always" } } } } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{ "$schema": "https://raw.githubusercontent.com/dotnet/Nerdbank.GitVersioning/master/src/NerdBank.GitVersioning/version.schema.json", "version": "1.0.0", "publicReleaseRefSpec": [ "^refs/heads/master$", "^refs/heads/v\\d+(?:\\.\\d+)?$" ], "cloudBuild": { "setVersionVariables": true, "buildNumber": { "enabled": true, "includeCommitId": { "when": "always" } } } } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for quotes, and do we need
required: true
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because it's a type: choice, I don't think we need to add required: true as it's a dropdown menu. I will remove the single quote tho!