Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add replication enabled attribute in pi volume resource #4007

Merged
merged 2 commits into from
Sep 12, 2022
Merged

Add replication enabled attribute in pi volume resource #4007

merged 2 commits into from
Sep 12, 2022

Conversation

dhirendersingh19
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

=== RUN   TestAccIBMPIVolumebasic
--- PASS: TestAccIBMPIVolumebasic (130.20s)
PASS
=== RUN   TestAccIBMPIVolumePool
--- PASS: TestAccIBMPIVolumePool (94.04s)
PASS
=== RUN   TestAccIBMPIVolumeGRS
--- PASS: TestAccIBMPIVolumeGRS (188.75s)
PASS

@dhirendersingh19 dhirendersingh19 marked this pull request as ready for review September 5, 2022 07:41
yussufsh
yussufsh requested changes Sep 8, 2022
View reviewed changes
Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes needed

ibm/service/power/resource_ibm_pi_volume_test.go Outdated Show resolved Hide resolved
ibm/service/power/resource_ibm_pi_volume_test.go Show resolved Hide resolved
@dhirendersingh19 dhirendersingh19 requested review from yussufsh and removed request for hkantare and rmoralesjr September 9, 2022 06:12
yussufsh
yussufsh approved these changes Sep 12, 2022
View reviewed changes
Copy link
Collaborator

@yussufsh yussufsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
cc @hkantare

@yussufsh yussufsh requested a review from hkantare September 12, 2022 06:57
@hkantare hkantare merged commit ba8f53e into IBM-Cloud:master Sep 12, 2022
SunithaGudisagarIBM pushed a commit to ibm-vpc/terraform-provider-ibm that referenced this pull request Sep 14, 2022
@dhirendersingh19 @SunithaGudisagarIBM1
Add replication enabled attribute in pi volume resource (IBM-Cloud#4007)
7040eaf 
* Add replication enabled attribute in volume resource

* Test case config refactored
SunithaGudisagarIBM pushed a commit to ibm-vpc/terraform-provider-ibm that referenced this pull request Sep 14, 2022
@dhirendersingh19 @SunithaGudisagarIBM1
Add replication enabled attribute in pi volume resource (IBM-Cloud#4007)
817148a 
* Add replication enabled attribute in volume resource

* Test case config refactored
@yussufsh yussufsh added the service/Power Systems Issues related to Power Systems label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare approved these changes

@yussufsh yussufsh yussufsh approved these changes

Assignees
No one assigned
Labels
service/Power Systems Issues related to Power Systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhirendersingh19 @yussufsh @hkantare