Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate connection strings for IBM-cloud-databases #4050

Merged
merged 5 commits into from
Sep 23, 2022
Merged

Deprecate connection strings for IBM-cloud-databases #4050

merged 5 commits into from
Sep 23, 2022

Conversation

lornakelly
Copy link
Contributor

Add deprecation note for connectionstrings in favour of ibm_database_connection

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMDatabaseDataSource_basic
=== PAUSE TestAccIBMDatabaseDataSource_basic
=== CONT  TestAccIBMDatabaseDataSource_basic
--- PASS: TestAccIBMDatabaseDataSource_basic (641.03s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database        642.116s

@lornakelly lornakelly force-pushed the lk/ibm-deprecate-connection-strings branch from 0af1d46 to c7c5f2b Compare September 22, 2022 08:43
@obai-1
Copy link
Collaborator

obai-1 commented Sep 22, 2022

@lornakelly we should also deprecate connectionstrings in ibm/service/database/resource_ibm_database.go

@lornakelly lornakelly force-pushed the lk/ibm-deprecate-connection-strings branch from d3cfb9f to fcb457a Compare September 23, 2022 13:32
@obai-1 obai-1 merged commit d8a1b45 into IBM-Cloud:master Sep 23, 2022
hkantare pushed a commit that referenced this pull request Oct 3, 2022
@lornakelly @hkantare
Deprecate connection strings for IBM-cloud-databases (#4050)
fc19770 
* Add deprecated fields
* Update docs
* Add deprecate message in resource as well
* Updated readme docs

Co-authored-by: Lorna-Kelly <lorna.kelly@ibm.com>
@omaraibrahim omaraibrahim mentioned this pull request Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omaraibrahim omaraibrahim omaraibrahim left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lornakelly @obai-1 @omaraibrahim