Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed connection string and cert path from datasource ibm-database #4406

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Removed connection string and cert path from datasource ibm-database #4406

merged 4 commits into from
Jul 24, 2023

Conversation

omaraibrahim
Copy link
Collaborator

@omaraibrahim omaraibrahim commented Mar 14, 2023 •
edited by obai-1
Loading

We deprecated connection strings for IBM-cloud-databases in this PR: #4050

We will no long support the use of connectionstrings and we will remove it. Please use ibm_database_connection datasource instead.

For more details please see the following blog post: https://www.ibm.com/cloud/blog/announcements/new-features-and-rearchitecturing-of-ibm-cloud-databasess-terraform-provider about deprecated attributes

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TEST=./ibm/service/database TESTARGS='-run=TestAccIBMDatabaseDataSource_basic'
--- PASS: TestAccIBMDatabaseDataSource_basic (940.89s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database	941.943s
...

@omaraibrahim omaraibrahim marked this pull request as ready for review July 6, 2023 13:44
@omaraibrahim omaraibrahim changed the title [WIP] - Removed connection string and cert path from datasource ibm-database Removed connection string and cert path from datasource ibm-database Jul 6, 2023
@omaraibrahim omaraibrahim force-pushed the remove_connection_string/34729 branch from ecaf184 to 3787593 Compare July 20, 2023 20:38
@obai-1 obai-1 merged commit 0bead53 into IBM-Cloud:master Jul 24, 2023
benbuchanan pushed a commit to benbuchanan/terraform-provider-ibm that referenced this pull request Aug 17, 2023
@omaraibrahim @benbuchanan
Remove deprecated connection string and cert path from datasource ibm…
c40778f 
…-database (IBM-Cloud#4406)

* removed connection string and cert path from datasource ibm-database
* updated docs
* removed cert_file_path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obai-1 obai-1 obai-1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omaraibrahim @obai-1