Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trustDefaultCerts=true by default in liberty configuration (server.xml) #2271

Closed
JohnTimm opened this issue Apr 22, 2021 · 2 comments
Closed

trustDefaultCerts=true by default in liberty configuration (server.xml) #2271

JohnTimm opened this issue Apr 22, 2021 · 2 comments
Assignees
@JohnTimm
Labels
enhancement New feature or request

Comments

@JohnTimm
Copy link
Collaborator

Per OpenLiberty documentation (https://openliberty.io/docs/21.0.0.3/reference/config/ssl.html):

Specifies whether the trust manager can establish trust by using the  default certificates. If set to true, then the default certificates are  used in addition to the configured truststore file to establish trust.  The attribute is set to false by default.
@JohnTimm JohnTimm self-assigned this Apr 22, 2021
JohnTimm added a commit that referenced this issue Apr 22, 2021
@JohnTimm
Issue #2271 - update default liberty config
703f885 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Apr 22, 2021
@JohnTimm
Issue #2271 - moved to configDropins/defaults/trustDefaultCerts.xml
17ce66e 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Apr 22, 2021
@JohnTimm
Issue #2271 - renamed to trustDefault.xml to match env variable approach
942de35 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Apr 22, 2021
@JohnTimm
Issue #2271 - update docs for trustDefault.xml config dropin
d631583 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Apr 22, 2021
@JohnTimm
Issue #2269, #2271, #2198 - miscellaneous updates (#2270)
d4a7538 
* Issue #2269 - support multiple graph term service providers

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2269 - doc updates

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2271 - update default liberty config

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2271 - moved to configDropins/defaults/trustDefaultCerts.xml

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2271 - renamed to trustDefault.xml to match env variable approach

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2198 - added FHIR terminology service diagram

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2198 - doc updates per PR feedback

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2198 - change configuration to configurations

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2271 - update docs for trustDefault.xml config dropin

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@prb112 prb112 added the enhancement New feature or request label Apr 26, 2021
@prb112
Copy link
Contributor

prb112 commented Apr 27, 2021

Already added - moved to QA
https://github.com/IBM/FHIR/blob/d4a7538816320c473178631abfadc6520f632703/fhir-server/liberty-config/configDropins/defaults/trustDefault.xml

@kmbarton423
Copy link
Contributor

kmbarton423 commented May 5, 2021 •
edited
Loading

Built/ran Docker container with default FHIR server configuration.
Added SNOMED to the FHIR server configuration (remoteTermServiceProviders).
Confirmed successful code lookup to SNOMED when variable SEC_TLS_TRUSTDEFAULTCERTS defaults true.

Below are the contents of trustDefault.xml:

<server description="fhir-server"> <ssl id="defaultSSLConfig" trustDefaultCerts="${SEC_TLS_TRUSTDEFAULTCERTS}"/> <variable name="SEC_TLS_TRUSTDEFAULTCERTS" defaultValue="true"/> </server>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JohnTimm JohnTimm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@prb112 @JohnTimm @kmbarton423