Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to configure multiple GraphTermServiceProvider instances #2269

Closed
JohnTimm opened this issue Apr 22, 2021 · 2 comments
Closed

Add support to configure multiple GraphTermServiceProvider instances #2269

JohnTimm opened this issue Apr 22, 2021 · 2 comments
Assignees

Comments

@JohnTimm
Copy link
Collaborator

In order to flexibly support user-defined segmentation of code system content across one or more graph databases and for consistency with RemoteTermServiceProvider we would like to allow for multiple configuration elements in fhir-server-config.json as follows:

            "graphTermServiceProviders": [{
                "__comment": "Configuration for Berkeley DB Java Edition + Lucene",
                "enabled": false,
                "configuration": {
                    "storage.backend": "berkeleyje",
                    "storage.directory": "data/graph",
                    "index.search.backend": "lucene",
                    "index.search.hostname": "data/searchindex",
                    "storage.read-only": true,
                    "query.batch": true,
                    "query.batch-property-prefetch": true,
                    "query.fast-property": true
                }
            },{
                "__comment": "Configuration for Apache Cassandra + ElasticSearch",
                "enabled": true,
                "timeLimit": 10000,
                "configuration": {
                    "storage.backend": "cql",
                    "storage.hostname": "127.0.0.1",
                    "index.search.backend": "elasticsearch",
                    "index.search.hostname": "127.0.0.1:9200",
                    "storage.read-only": true,
                    "query.batch": true,
                    "query.batch-property-prefetch": true,
                    "query.fast-property": true
                }
            }],
@JohnTimm JohnTimm self-assigned this Apr 22, 2021
JohnTimm added a commit that referenced this issue Apr 22, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Apr 22, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm JohnTimm added this to the Sprint 2021-05 milestone Apr 22, 2021
JohnTimm added a commit that referenced this issue Apr 22, 2021
* Issue #2269 - support multiple graph term service providers

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2269 - doc updates

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2271 - update default liberty config

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2271 - moved to configDropins/defaults/trustDefaultCerts.xml

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2271 - renamed to trustDefault.xml to match env variable approach

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2198 - added FHIR terminology service diagram

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2198 - doc updates per PR feedback

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2198 - change configuration to configurations

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2271 - update docs for trustDefault.xml config dropin

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@lmsurpre
Copy link
Member

When I started my server with the old config, it failed with a NPE. We need to handle the absence of config parameters just as well as their presence.

@lmsurpre
Copy link
Member

I opened a PR to address this config issue and that has been merged.

JohnTimm added a commit that referenced this issue May 17, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue May 18, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue May 19, 2021
* Issue #2296 - implement server resolve function

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2296 - fix resolveInternalFragmentReference

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2296 - updates

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2269 - updates

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2269 - updates

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2296 - updates

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2296 - updates

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2296 - updates

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2296 - unit tests with mock persistence layer

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2296 - updates per PR review comments

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2296 - changed ServerResolveFunction method visibility

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2296 - updated FHIRServerUsersGuide.md

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2296 - added matchesServiceBaseUrl method

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2296 - added tests for versioned and absolute references

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants