Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #2269, #2271, #2198 - miscellaneous updates #2270

Merged
merged 9 commits into from
Apr 22, 2021
Merged

Issue #2269, #2271, #2198 - miscellaneous updates #2270

merged 9 commits into from
Apr 22, 2021

Conversation

JohnTimm
Copy link
Collaborator

Signed-off-by: John T.E. Timm johntimm@us.ibm.com

@JohnTimm
Issue #2269 - support multiple graph term service providers
d408998 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm JohnTimm requested a review from lmsurpre April 22, 2021 15:28
@JohnTimm
Issue #2269 - doc updates
17ad2b5 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm JohnTimm requested a review from prb112 April 22, 2021 15:39
prb112
prb112 reviewed Apr 22, 2021
View reviewed changes
Copy link
Contributor

@prb112 prb112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments on the docs

prb112
prb112 reviewed Apr 22, 2021
View reviewed changes
Copy link
Contributor

@prb112 prb112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnTimm
Issue #2271 - update default liberty config
703f885 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm JohnTimm changed the title Issue #2269 - support multiple graph term service providers Issue #2269, #2271 - support multiple graph term service providers Apr 22, 2021
@JohnTimm JohnTimm changed the title Issue #2269, #2271 - support multiple graph term service providers Issue #2269, #2271 - miscellaneous updates Apr 22, 2021
@JohnTimm
Issue #2271 - moved to configDropins/defaults/trustDefaultCerts.xml
17ce66e 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm
Issue #2271 - renamed to trustDefault.xml to match env variable approach
942de35 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm
Issue #2198 - added FHIR terminology service diagram
6f7a6c9 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm JohnTimm changed the title Issue #2269, #2271 - miscellaneous updates Issue #2269, #2271, #2198 - miscellaneous updates Apr 22, 2021
@JohnTimm JohnTimm requested a review from prb112 April 22, 2021 18:50
lmsurpre
lmsurpre approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple comments, but looks good. LGTM.

@JohnTimm
Issue #2198 - doc updates per PR feedback
01ff258 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm
Issue #2198 - change configuration to configurations
2c99a55 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm
Issue #2271 - update docs for trustDefault.xml config dropin
d631583 
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm JohnTimm merged commit d4a7538 into main Apr 22, 2021
@JohnTimm JohnTimm deleted the johntimm-main branch April 22, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmsurpre lmsurpre lmsurpre approved these changes

@prb112 prb112 Awaiting requested review from prb112

Assignees
No one assigned
Labels
configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnTimm @prb112 @lmsurpre