Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI-5277/ separate addon code from controller server #656

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

CSI-5277/ separate addon code from controller server #656

wants to merge 6 commits into from

Conversation

matancarmeli7
Copy link
Contributor

@matancarmeli7 matancarmeli7 commented Feb 8, 2023 •
edited
Loading

@matancarmeli7
separate addon code from controller server
e44ba73 
Signed-off-by: matancarmeli7 <matan.carmeli7@gmail.com>
@matancarmeli7
fix unit tests
583fc2d 
Signed-off-by: matancarmeli7 <matan.carmeli7@gmail.com>
@matancarmeli7 matancarmeli7 requested review from ArbelNathan, ELENAGER and a team February 8, 2023 12:25
@matancarmeli7 matancarmeli7 changed the title separate addon code from controller server CSI-5277/ separate addon code from controller server Feb 8, 2023
This was referenced Feb 8, 2023
Open
Open
matancarmeli7 and others added 3 commits February 12, 2023 17:44
@matancarmeli7
unify server_manager
651d221 
Signed-off-by: matancarmeli7 <matan.carmeli7@gmail.com>
@matancarmeli7
Merge branch 'develop' into task/CSI-5277_separate_addons_code_from_c…
f7bb94b 
…ontroller_server
@matancarmeli7
remove identity_controller_servicer.py
6287eee 
Signed-off-by: matancarmeli7 <matan.carmeli7@gmail.com>
ArbelNathan
ArbelNathan approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@ArbelNathan ArbelNathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ArbelNathan
ArbelNathan previously approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@ArbelNathan ArbelNathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erantzabari erantzabari erantzabari approved these changes

@ArbelNathan ArbelNathan ArbelNathan approved these changes

@ELENAGER ELENAGER Awaiting requested review from ELENAGER

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matancarmeli7 @ArbelNathan @erantzabari