Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI-5277/ add identity servicer #658

Open
wants to merge 5 commits into
base: task/CSI-5277_organize_directories
Choose a base branch
from
Open

CSI-5277/ add identity servicer #658

wants to merge 5 commits into from

Conversation

matancarmeli7
Copy link
Contributor

@matancarmeli7 matancarmeli7 commented Feb 8, 2023 •
edited
Loading

@matancarmeli7
add identity unit tests
e477638 
Signed-off-by: matancarmeli7 <matan.carmeli7@gmail.com>
@matancarmeli7 matancarmeli7 requested review from ArbelNathan, ELENAGER and a team February 8, 2023 12:26
@matancarmeli7 matancarmeli7 changed the title add identity unit tests CSI-5277/ add identity unit tests Feb 8, 2023
This was referenced Feb 8, 2023
Open
Open
matancarmeli7 and others added 3 commits February 15, 2023 10:00
@matancarmeli7
Merge branch 'task/CSI-5277_organize_directories' into task/CSI-5277_…
70f7d40 
…add_unittests_to_identity_servicer
@matancarmeli7
Merge branch 'task/CSI-5277_organize_directories' into task/CSI-5277_…
5c139d9 
…add_unittests_to_identity_servicer
@matancarmeli7
add identity controller servicer
20f51d4 
Signed-off-by: matancarmeli7 <matan.carmeli7@gmail.com>
@matancarmeli7 matancarmeli7 changed the title CSI-5277/ add identity unit tests CSI-5277/ add identity servicer Feb 15, 2023
ArbelNathan
ArbelNathan approved these changes Feb 16, 2023
View reviewed changes
Copy link
Contributor

@ArbelNathan ArbelNathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erantzabari erantzabari erantzabari approved these changes

@ArbelNathan ArbelNathan ArbelNathan approved these changes

@ELENAGER ELENAGER Awaiting requested review from ELENAGER

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matancarmeli7 @ArbelNathan @erantzabari