Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memory leak when using go-metrics #1219

Closed
mengqinglai opened this issue Nov 16, 2018 · 0 comments
Closed

memory leak when using go-metrics #1219

mengqinglai opened this issue Nov 16, 2018 · 0 comments

Comments

@mengqinglai
Copy link

https://github.com/Shopify/sarama/blob/cebb5847efade319a00e1888acfd8bcdb393e478/broker.go#L108

b.incomingByteRate is inited by NewMeter, b.incomingByteRate.Stop() should be called when Broker was closed.
jsoriano added a commit to elastic/sarama that referenced this issue Dec 7, 2018
@jsoriano
Unregister all broker metrics on broker stop
82be3b4 
Add methods for registering broker-specific metrics so it is possible to
keep track of them and they can be unregistered on broker stop.

Fixes IBM#1219
@jsoriano jsoriano mentioned this issue Dec 7, 2018
Merged
jsoriano added a commit to elastic/sarama that referenced this issue Dec 9, 2018
@jsoriano
Unregister all broker metrics on broker stop
78e265b 
Add methods for registering broker-specific metrics so it is possible to
keep track of them and they can be unregistered on broker stop.

Fixes IBM#1219
@bai bai closed this as completed in #1232 Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mengqinglai