Unregister all broker metrics on broker stop #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add methods for registering broker-specific metrics so it is possible to keep track of them and they can be unregistered on broker stop. Fixes IBM#1219
|
I think there can still be another leak with topic metrics, as they are never unregistered, I'll take a look to this as a follow up. |
This was referenced Dec 9, 2018
|
@bai Checks appear to be passing, is it possible to approve this PR ? |
|
Can you please look into writing a test around it? |
sam-obeid
reviewed
Feb 15, 2019
| b.conf.MetricRegistry.Unregister(getMetricNameForBroker("outgoing-byte-rate", b)) | ||
| b.conf.MetricRegistry.Unregister(getMetricNameForBroker("response-rate", b)) | ||
| } | ||
| b.unregisterMetrics() |
There was a problem hiding this comment.
I am not sure you need to maintain the list of registered metrics here, could you replace this method with:
Suggested change
| b.unregisterMetrics() | |
| b.conf.MetricRegistry.UnregisterAll() |
The MetricRegistry instance of scoped to a single broker instance, so once broker.Close() is called, we can Unregister all metrics attached to that broker.
There was a problem hiding this comment.
Wouldn't UnregisterAll() also unregister the global metrics shared between brokers?
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add methods for registering broker-specific metrics so it is possible to
keep track of them and they can be unregistered on broker stop.
Fixes #1219