Fix ConfigResourceType to match the protocol and server. #1551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
was erroneously setup identical to the ACL Resources and therefore (a) had more types than describe and alter config operations actually supported (they only support Broker and Topic types) and (b) had the wrong integer values. See reference for actual integer constants that the server is expecting.
bradw456
force-pushed
the
bugfix/config-resource-type
branch
from
36f9f7d
to
455f6ad
Compare
|
@bradw456 ah sorry I hadn't seen this PR. I had spotted this same problem and included it in my (now merged) PR #1571 which was fixing a related issue with DescribeConfigRequest and BrokerResourceType where I'd noticed it was sending the wrong integer values for the given ResourceTypes and I was getting confusing responses back |
|
Thanks @dnwe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The struct was erroneously setup identical to the ACL Resources and therefore
(a) had more types than describe and alter config operations actually
supported (they only support Broker and Topic types) and (b) had the
wrong integer values. See reference for actual integer constants
that the server is expecting.