fix: use the broker for any admin on BrokerConfig #1571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When operating on Broker configuration via the Admin API, the request _must_ be sent to the specific broker that the change applies to, _not_ just (as usual) to the Controller.
|
@mimaison thanks for the review — I've incorporate your suggestions into the commit and force pushed it up, it is ready for re-review |
|
LGTM, thanks for contributing again and thanks @mimaison for reviewing. Let me know if you think it's ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When operating on Broker configuration via the Admin API, the request
must be sent to the specific broker that the change applies to, not
just (as usual) to the Controller.