-
Notifications
You must be signed in to change notification settings - Fork 36
Fix issue 12 and extend CI tests to additional Python versions/OSes #13
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber stamp.
a7fcb0c
@dangunter not sure what's the status for Python 3.9 but we can try to see how it behaves if we remove the workaround once we start supporting 3.9. In the meanwhile, what I'm getting from tornadoweb/tornado#2608 is that, for the time being, this should be dealt with on the side of the application: so our workaround is the recommended way to address this. In any case he issue looks quite active and we can use it as a reference to see if there's any progress. I've added this information as a comment in the code, so if you're OK with the wording you can go ahead and re-approve it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #12
Proposed changes:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: