Added support for Presentation 3 services property #89
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
id
in addition to@id
to find services from parent resourcesservices
to pool of services to check when listing all services.For 3. an alternative to always checking would be to determine that the service doesn't have enough data:
Which references this in the
manifest.services
block:The lack of profile might be enough? It's possible that in misconfigured manifests this would cause issues, if you had 2 services with the same identifier when you looked for the service recursively in the JSON-LD it would always resolve the first. Even if that service had a different structure.
I believe this is correct behaviour though, short of merging all services we find. cc @tomcrane