Prevent overwriting services #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests are expected to fail until IIIF-Commons/manifesto#89 is merged |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
@stephenwf, I'm doing some work to bring manifold up to date and found this long-abandoned PR. I extracted the test infrastructure you added here as a general-purpose improvement. However, your tests pass with or without the remaining code changes in this PR, so I'm wondering if this work ended up getting resolved in some different way over the intervening years. Is there still anything important here, or should I close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a resource is dereferenced and loaded the body is passed through a step where the auth is extracted. This ensures that if there were services embedded in the manifest but not in the dereferenced resource they are not overwritten. Added tests to cover the previously working BL AV manifest and the new structure with a change in where the probe service resides.