Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Selectors section to Registry; move/update imageAPISelector context #2231

Merged
merged 24 commits into from
Mar 20, 2024

Conversation

kirschbombe
Copy link
Contributor

@kirschbombe kirschbombe commented Apr 25, 2023

This PR:

  • creates a new folder/section in the registry for "Selectors"
  • edits the old openannotation index page to focus on selectors, not web anno extensions
  • copies the current imageAPISelector context from annex to registry/selectors
  • updates the imageAPISelector context to point to the current version of image api instead of specific version
  • change the ImageApiSelector context to include all selectors - so now it's the Selectors context
  • adds note to ImageApiSelector documentation that the default values in the table are for Image 3 and that implementers should consult previous versions for their default values
  • includes the selectors context in presentation 3 context so it doesn't need to be imported separately
  • update link to selectors registry in presi 3 documentation
  • add mention of webanno selectors and FragmentSelector to Selectors registry
  • updates change log

Preview: https://preview.iiif.io/api/image-api-selector-update/registry/selectors/
Context preview: https://preview.iiif.io/api/image-api-selector-update/registry/selectors/context.json

@kirschbombe kirschbombe requested review from a team, zimeon, azaroth42, tomcrane, mikeapp and mixterj and removed request for a team April 25, 2023 20:22
source/registry/selectors/index.md Outdated Show resolved Hide resolved
source/registry/selectors/index.md Outdated Show resolved Hide resolved
source/registry/selectors/index.md Outdated Show resolved Hide resolved
@azaroth42
Copy link
Member

Context should use scoped contexts to limit the definition of the properties to only the class.... and define the class.

@thehabes
Copy link
Contributor

thehabes commented May 4, 2023

Hi all, just sharing some research and results from the JSON LD playground today.

We get jsonld.SyntaxError: Invalid JSON-LD syntax; invalid scoped context. from this context as it is now. We have narrowed it down to two issues

  1. This context needs a "iiif_selectors":"http://iiif.io/api/__TODO__/#" entry
  2. Under ImageAPISelector in the @context array it tries to scope in "http://iiif.io/api/image/#". This needs to be the context.json and so should be "https://iiif.io/api/image/3/context.json" if you need that context in there.

I am happy to report that we produced a test object which combined this context, the IIIF Presentation API 3 context, and the Goereference Extension context which was processed correctly in the JSON-LD playground. It raised a couple other questions that need researched but it is a promising result. Below is what we found out.

Go Here to see the test object that we brute force embedded the contexts into.
See It Process in the JSON-LD playground.

@mikeapp mikeapp mentioned this pull request May 12, 2023
Copy link
Member

@zimeon zimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor issue noted with duplicate defn. of [registry-selectors] but otherwise looks good

mikeapp
mikeapp previously approved these changes May 31, 2023
@kirschbombe
Copy link
Contributor Author

kirschbombe commented Sep 26, 2023

The presi 3 context is updated to include the selectors context. A big thanks to @thehabes for testing the context and helping me simplify it.

@kirschbombe kirschbombe marked this pull request as ready for review February 28, 2024 19:21
@JulieWinchester JulieWinchester merged commit fb5858e into main Mar 20, 2024
@azaroth42 azaroth42 deleted the image-api-selector-update branch October 24, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants