r_comp: Don't treat trailing space as comment continuation #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefft0
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Replicode spec says that a comment ending in " .." is continued to the next line. The preprocessor handles this and checks for "..". But it also treats a single space as a comment continuation. This causes problems since it is common for a comment to end in a space (since it's difficult to see in the text editor). This appeared as a problem in Linux where the end of line is just a newline (not like carriagereturn/newline in Windows). The handling of end of lines is a separate issue. This PR simply changes the preprocessor to not treat an ending space as a comment continuation.