Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End date not honored by CLI/Python API #48

Merged

Conversation

mfacchinelli
Copy link
Contributor

Change Summary

Overview

New Dependencies

When using the CLI/Python APIs to request data for a specific time period, the end date does not seem to be respected.

New Files

None

Deleted Files

None

Updated Files

  • cli.py: added end_date to list of valid arguments

Testing

Tested locally in Python and CLI.

Copy link
Contributor

@maxinelasp maxinelasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change! I tested it locally and all looks good to me

Copy link
Contributor

@anamanica anamanica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I tell, this looks good! Thanks for adding that end-date query

@daralynnrhode
Copy link
Contributor

Thanks for doing this!

@greglucas greglucas merged commit 5734be6 into IMAP-Science-Operations-Center:main Jun 20, 2024
13 checks passed
@daralynnrhode daralynnrhode linked an issue Aug 9, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG : --end-date query parameter not working
5 participants