Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Table Output #64

Conversation

daralynnrhode
Copy link
Contributor

@daralynnrhode daralynnrhode commented Jul 12, 2024

Updating the Query Table Output

Overview

Making the output table larger to accommodate longer strings and be a bit easier to read.

Here is the Original Output:
Screen Shot 2024-07-12 at 10 46 44 AM

And Here is what I changed it to:
Screen Shot 2024-07-12 at 10 45 57 AM

Let me know if you have any preferences!

Closes #57

New Dependencies

New Files

Deleted Files

Updated Files

  • cli.py
    • edits made to format_string and hyphens

Testing

@daralynnrhode daralynnrhode self-assigned this Jul 12, 2024
@daralynnrhode daralynnrhode requested review from greglucas and a team July 12, 2024 16:48
Copy link
Contributor

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks! I wonder if we are playing whack a mole and will be updating this when we get new lengths again. For the future (not this PR), I'm wondering if it'd be easy to dynamically adjust the widths or remove columns to make it easier to always accommodate the right size of fields.

Copy link
Contributor

@bourque bourque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daralynnrhode daralynnrhode merged commit d853580 into IMAP-Science-Operations-Center:main Jul 15, 2024
13 checks passed
@daralynnrhode daralynnrhode deleted the api_table_formatting branch July 15, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Access API Query Table Formatting Issue
3 participants