PR updates, naming changes

imap_processing/cli.py

@@ -23,8 +23,6 @@
 
 import imap_processing
 
-__logger__ = logging.getLogger(__name__)
-
 # TODO: change how we import things and also folder
 # structure may?
 # From this:
@@ -38,6 +36,8 @@
 from imap_processing.swe.l1a.swe_l1a import swe_l1a
 from imap_processing.swe.l1b.swe_l1b import swe_l1b
 
+logger = logging.getLogger(__name__)
+
 
 def _parse_args():
     """Parse the command line arguments.

imap_processing/mag/l0/decom_mag.py

@@ -80,15 +80,14 @@ def export_to_xarray(l0_data: list[MagL0]):
         xarray dataset for generating burst data CDFs
     """
     # TODO split by mago and magi using primary sensor
-    # TODO split by norm and burst
     norm_data = []
     burst_data = []
 
-    for datapoint in l0_data:
-        if datapoint.ccsds_header.PKT_APID == Mode.NORMAL:
-            norm_data.append(datapoint)
-        if datapoint.ccsds_header.PKT_APID == Mode.BURST:
-            burst_data.append(datapoint)
+    for packet in l0_data:
+        if packet.ccsds_header.PKT_APID == Mode.NORMAL:
+            norm_data.append(packet)
+        if packet.ccsds_header.PKT_APID == Mode.BURST:
+            burst_data.append(packet)
 
     norm_dataset = None
     burst_dataset = None

imap_processing/mag/l1a/mag_l1a.py

@@ -5,7 +5,7 @@
 from imap_processing.cdf.utils import write_cdf
 from imap_processing.mag.l0 import decom_mag
 
-__logger__ = logging.getLogger(__name__)
+logger = logging.getLogger(__name__)
 
 
 def mag_l1a(packet_filepath, output_filepath_norm, ouptput_filepath_burst):

imap_processing/tests/mag/test_mag_decom.py

@@ -53,7 +53,6 @@ def test_mag_raw_xarray():
     assert all([item is not None for _, item in burst_data.attrs.items()])
 
     expected_norm_len = 17
-    print(norm_data.dims["Epoch"])
     assert norm_data.dims["Epoch"] == expected_norm_len
 
     expected_burst_len = 19
@@ -69,16 +68,18 @@ def test_mag_raw_cdf_generation(tmp_path):
 
     test_data_path_norm = tmp_path / "mag_l1a_raw-normal_20210101_20210102_v01-01.cdf"
 
+    assert not test_data_path_norm.exists()
     output = write_cdf(norm_data, test_data_path_norm)
-    assert Path.exists(test_data_path_norm)
+    assert test_data_path_norm.exists()
 
     input_xarray = cdf_to_xarray(output)
     assert input_xarray.attrs.keys() == norm_data.attrs.keys()
 
     test_data_path_burst = tmp_path / "mag_l1a_raw-burst_20210101_20210102_v01-01.cdf"
 
+    assert not test_data_path_burst.exists()
     output = write_cdf(burst_data, test_data_path_burst)
-    assert Path.exists(test_data_path_burst)
+    assert test_data_path_burst.exists()
 
     input_xarray = cdf_to_xarray(output)
     assert input_xarray.attrs.keys() == burst_data.attrs.keys()