Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Hi L1a histogram #700

Closed
Tracked by #905
subagonsouth opened this issue Jul 22, 2024 · 0 comments · Fixed by #1196
Closed
Tracked by #905

Refactor Hi L1a histogram #700

subagonsouth opened this issue Jul 22, 2024 · 0 comments · Fixed by #1196
Assignees
Labels
Ins: Hi Related to the IMAP-Hi instrument Level: L1 Level 1 processing
Milestone

Comments

@subagonsouth
Copy link
Contributor

subagonsouth commented Jul 22, 2024

Algorithm Description:

Due to changes in PR #687, the allocate_histogram_dataset function is probably no longer needed. Check the TODOs in the create_dataset function and refactor the code as you see fit.

Note from the PR:

The allocate_histogram_dataset function was really just my way of avoiding having an intermediate data storage. I wanted to go directly from the packet into the xr.DataSet arrays. With your new function, this is no longer achieving that goal. I will write a ticket to look at this Hi code and address the TODOs.

In addition to the above, this should also address the TODO on line ~60:

    # TODO: Look into avoiding the for-loops below
    #       It seems like we could try to reshape the arrays and do some numpy
    #       broadcasting rather than for-loops directly here. Ticket: #700
@subagonsouth subagonsouth added Ins: Hi Related to the IMAP-Hi instrument Level: L1 Level 1 processing labels Jul 22, 2024
@subagonsouth subagonsouth self-assigned this Jul 22, 2024
@bourque bourque added this to the Release v0.6.x / Sept 2024 milestone Sep 3, 2024
@bourque bourque removed this from Release v0.5.x Sep 3, 2024
@tech3371 tech3371 modified the milestones: Sept 2024, Oct 2024 Sep 30, 2024
@subagonsouth subagonsouth mentioned this issue Oct 2, 2024
4 tasks
@bourque bourque modified the milestones: Oct 2024, Nov 2024 Nov 4, 2024
@subagonsouth subagonsouth modified the milestones: Nov 2024, Dec 2024 Nov 26, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in IMAP Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ins: Hi Related to the IMAP-Hi instrument Level: L1 Level 1 processing
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants