Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swe l1a validation data #1038

Merged
merged 1 commit into from
Oct 23, 2024
Merged

swe l1a validation data #1038

merged 1 commit into from
Oct 23, 2024

Conversation

tech3371
Copy link
Contributor

Change Summary

closes #1036

Overview

Validate SWE L1A data

Deleted Files

  • imap_processing/tests/swe/decompressed/
    • deleted old validation data

Updated Files

  • imap_processing/tests/swe/conftest.py
    • updated test to read validation data
  • imap_processing/tests/swe/test_swe_l1a_science.py
    • update tests

@tech3371 tech3371 added Ins: SWE Related to the SWE instrument Level: L1 Level 1 processing labels Oct 21, 2024
@tech3371 tech3371 self-assigned this Oct 21, 2024
@tech3371 tech3371 requested review from a team, bourque, sdhoyt and subagonsouth and removed request for a team October 21, 2024 23:03
subagonsouth
subagonsouth approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@subagonsouth subagonsouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Just had the one question about the test data that you have been provided.

@tech3371 tech3371 merged commit d6daf1b into IMAP-Science-Operations-Center:dev Oct 23, 2024
17 checks passed
sdhoyt
sdhoyt approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@sdhoyt sdhoyt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Edit: Looks like I opened to this page before you merged and didn't refresh before finishing the review lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdhoyt sdhoyt sdhoyt approved these changes

@subagonsouth subagonsouth subagonsouth approved these changes

@bourque bourque Awaiting requested review from bourque bourque was automatically assigned from IMAP-Science-Operations-Center/sdc-random-1

Assignees

@tech3371 tech3371

Labels
Ins: SWE Related to the SWE instrument Level: L1 Level 1 processing
Projects
IMAP
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

L1A Science Data validation
3 participants
@tech3371 @sdhoyt @subagonsouth