1045 hi l1b modify processing workflow to use xarraydatasetupdate #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subagonsouth
added
Ins: Hi
…taset in-place instead of assign which copies
subagonsouth
force-pushed
the
1045-hi-l1b-modify-processing-workflow-to-use-xarraydatasetupdate
branch
from
6755641 to
9622ab0
Compare
laspsandoval
approved these changes
Oct 30, 2024
subagonsouth
merged commit 8502799
into
IMAP-Science-Operations-Center:dev
17 checks passed
subagonsouth
deleted the
1045-hi-l1b-modify-processing-workflow-to-use-xarraydatasetupdate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
These are all just changes to address a comment that @laspsandoval made in a recent Hi PR. I was using
xarray.Dataset.assign()to add new variables to a dataset and Laura pointed out that I should useupdate()to do an in-place modification of the dataset rather than usingassign()which does acopy()behind the scenes. I don't like to mutate inputs to functions, so I now output a dictionary containing thexarray.Dataarrayobjects to be added to the dataset and then call.update()in the outer function to add those to the outputxarray.Dataset.Closes: #1045