-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process multiple CoDICE APIDs per input file #1162
Process multiple CoDICE APIDs per input file #1162
Conversation
… datasets from process_codice_l1a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, it looks great to me. I had few clarification questions.
for counter, variable_name in zip( | ||
range(all_data.shape[1]), self.config["variable_names"] | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still have trouble understanding relationship between data's shape and variables names. Will this change in future PR? If so, ignore my comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For example, for the lo-sw-priorty
data product, the dimensions of all_data
in this case is (35, 5, 1, 12, 128)
. That is for 35 epochs, 5 species (or what I generically call "counters"), 1 position, 12 spin sectors, and 128 energy steps.
The data for each counter needs to be in its own CDF variable, so in order to iterate over each counter, I am iterating over all_data.shape[1]
.
I can add some comments in the code here to make it more clear, because it is quite confusing 😓
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand. CoDICE is complicated but you are doing great job at setting up common processing code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good setup for upcoming PR. Makes sense to me
Change Summary
Overview
Apologies for the large PR here. I found that it was difficult to split this up into smaller chunks since several aspects of this are dependent on each other.
This PR
Closes #769 and #992
New Files
imap_processing/tests/codice/data/imap_codice_l0_raw_20241110_v001.pkts
Deleted Files
Updated Files
imap_processing/cdf/config/imap_codice_global_cdf_attrs.yaml
imap_processing/cdf/config/imap_codice_l1a_variable_attrs.yaml
imap_processing/codice/codice_l1a.py
imap_processing/codice/constants.py
hi-counters-singles
imap_processing/codice/decompress.py
imap_processing/codice/utils.py
hi-priorities
data productimap_processing/tests/codice/conftest.py
imap_processing/tests/codice/test_codice_l0.py
imap_processing/tests/codice/test_codice_l1a.py
imap_processing/tests/codice/test_codice_l1b.py
imap_processing/tests/codice/test_decompress.py