Lo - Create L1A Direct Event CDFs #1221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdhoyt
added
Ins: Lo
sdhoyt
requested review from
bourque,
subagonsouth,
tech3371 and
joycecj
and removed request for
a team
tech3371
reviewed
Dec 13, 2024
| @@ -127,6 +127,7 @@ direct_events: | |||
| CATDESC: Index of number of direct events for pointing | |||
| FIELDNAM: direct_events | |||
| LABLAXIS: DE | |||
| LABL_PTR_1: direct_events_label | |||
There was a problem hiding this comment.
Do you want to move this upto line 50? It seems like you are inheriting de_default a lot and it has depend_1. If it has depend_1, it also needs labl_prt_1. I don't remember if ISTP check catches that or not but it will be something you will come across later.
| @@ -146,7 +147,7 @@ esa_step: | |||
| VALIDMAX: 7 | |||
| FORMAT: I1 | |||
| CATDESC: Energy Step | |||
| DEPEND_1: esa_step | |||
| DEPEND_1: direct_events | |||
There was a problem hiding this comment.
could this be extra now since de_default already has it? you may just need to remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
Adds the DE processing code to the pipeline and adds L1A Direct Event Attributes to the processed dataset
Updated Files
Testing
Added check for L1A dataset logical source results for each product being created in the pipeline. Planning to add further attribute testing in the future
Closes #1013
Closes #1014