Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SWE: Review and correct phase space density units #1223

Merged
merged 3 commits into from
Dec 16, 2024
Merged

SWE: Review and correct phase space density units #1223

merged 3 commits into from
Dec 16, 2024

Conversation

tech3371
Copy link
Contributor

Change Summary

closes #1164

Overview

Reviewed and correct SWE phase space density units and conversion factors.

Updated Files

  • imap_processing/swe/l2/swe_l2.py
    • update doc strings with notes on electron speed units ocnversion and how conversion factors was calculated.
  • pyproject.toml
    • Added ignore for ruff

Testing

  • imap_processing/tests/swe/test_swe_l2.py
    • updated tests

@tech3371 tech3371 added the Ins: SWE Related to the SWE instrument label Dec 13, 2024
@tech3371 tech3371 requested review from sdhoyt, subagonsouth and a team December 13, 2024 22:41
@tech3371 tech3371 self-assigned this Dec 13, 2024
@tech3371 tech3371 requested review from bourque and removed request for a team December 13, 2024 22:41
subagonsouth
subagonsouth approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@subagonsouth subagonsouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tech3371 tech3371 merged commit 2e39c3d into IMAP-Science-Operations-Center:dev Dec 16, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subagonsouth subagonsouth subagonsouth approved these changes

@sdhoyt sdhoyt Awaiting requested review from sdhoyt

@bourque bourque Awaiting requested review from bourque bourque was automatically assigned from IMAP-Science-Operations-Center/sdc-random-1

Assignees

@tech3371 tech3371

Labels
Ins: SWE Related to the SWE instrument
Projects
IMAP
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SWE: Fix phase space density units
2 participants
@tech3371 @subagonsouth