Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWE: calculate flux #1227

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Conversation

tech3371
Copy link
Contributor

Change Summary

closes #885

Overview

Calculate flux using information and formula I have right. This may need update in future PR once Ruth provides me units worked out and correct conversion factors. This PR writes functional structure to calculate flux.

Updated Files

  • imap_processing/swe/l2/swe_l2.py
    • function to calculate flux

Testing

  • imap_processing/tests/swe/test_swe_l2.py

@tech3371 tech3371 added Ins: SWE Related to the SWE instrument Level: L2 Level 2 processing labels Dec 17, 2024
@tech3371 tech3371 requested a review from a team December 17, 2024 18:52
@tech3371 tech3371 self-assigned this Dec 17, 2024
@tech3371 tech3371 requested review from bourque, sdhoyt and subagonsouth and removed request for a team December 17, 2024 18:52
Copy link
Contributor

@subagonsouth subagonsouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A couple of minor nits.

imap_processing/swe/l2/swe_l2.py Show resolved Hide resolved
imap_processing/tests/swe/test_swe_l2.py Outdated Show resolved Hide resolved
imap_processing/tests/swe/test_swe_l2.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@bourque bourque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

imap_processing/swe/l2/swe_l2.py Show resolved Hide resolved
imap_processing/swe/l2/swe_l2.py Show resolved Hide resolved
@tech3371 tech3371 merged commit aec27bd into IMAP-Science-Operations-Center:dev Dec 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ins: SWE Related to the SWE instrument Level: L2 Level 2 processing
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

SWE: Calculate Electron flux
3 participants