Lo pkt definitions for housekeeping, sectored, angular,and priority counts #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GFMoraga
added
Ins: CoDICE
tech3371
approved these changes
Sep 13, 2023
| for certain number of packets. Change values where TODO is | ||
| """ | ||
|
|
||
| # TODO: change instrument name |
There was a problem hiding this comment.
since this won't change, we can delete this TODO
| module_path = f"{current_directory}/../../imap_processing" | ||
| packet_definition_path = f"{module_path}/{instrument_name}/packet_definitions" | ||
| # TODO: Copy packet definition to tools/xtce_generation/ folder | ||
| path_to_excel_file = ( |
There was a problem hiding this comment.
I would avoid committing local path.
I would do something like this
path_to_excel_file = f"{current_directory}/TLM_COD_20230629-110638(update).xlsx"
all someone else would need to do is copy excel file to tools/xtce_generation/ and update excel filename as needed if it's different.
GFMoraga
merged commit 1c617e6
into
IMAP-Science-Operations-Center:dev
12 checks passed
maxinelasp
pushed a commit
to maxinelasp/imap_processing
that referenced
this pull request
Oct 2, 2023
…ounts (IMAP-Science-Operations-Center#158) Added pkt definitions for housekeeping, sectored, angular,and priority counts.
laspsandoval
pushed a commit
to laspsandoval/imap_processing
that referenced
this pull request
Nov 15, 2023
…ounts (IMAP-Science-Operations-Center#158) Added pkt definitions for housekeeping, sectored, angular,and priority counts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
I added the rest of codice lo packets in xtce format. Also deleted some files that where not being used. changed directory to not be uppercase
Overview
Added codice packet definitions.
New Files
xtce_generator_codice.py7 packet definitions in xtce format
Deleted Files
decom_python_example.pyexample_xtce.xmlxtce_generator_template.py