-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I-ALiRT: L0 parsing #246
Merged
laspsandoval
merged 21 commits into
IMAP-Science-Operations-Center:dev
from
laspsandoval:dev
Nov 8, 2023
+1,063
−0
Merged
I-ALiRT: L0 parsing #246
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
57edfd6
adding ialirt
laspsandoval 1676ba5
updates
laspsandoval 711a4c0
adding hit decom
laspsandoval 01482f6
adding other instruments
laspsandoval 7d0ca70
update
laspsandoval 193595a
formatting
laspsandoval 374fa05
mistaken changes
laspsandoval 4b947a6
minor updates
laspsandoval 369cf3f
ruff fixes
laspsandoval 06b035a
response to PR
laspsandoval 5e68e3f
response to pr
laspsandoval 82f355b
xml update
laspsandoval f7ba8ce
update to xml
laspsandoval 89543d5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 11c064e
response to pr
laspsandoval e5e43cc
update to xml comments
laspsandoval ce5d5a6
added additional test
laspsandoval 8f6d69a
appease codecov
laspsandoval e74bfb4
appease codecov
laspsandoval 2778c49
appease codecov
laspsandoval 9d61fcc
pr response
laspsandoval File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
response to pr
commit 11c064e6b86d7c553d0884855754175c6c2cba03
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -73,13 +73,13 @@ | |
binary_file_path, "wb" | ||
) as binary_file: | ||
for line in text_file: | ||
if not line.startswith("#"): | ||
# Split the line by semicolons | ||
# Discard the first value since it is only a counter | ||
hex_values = line.strip().split(";")[1:] | ||
# Convert hex to binary | ||
binary_data = bytearray.fromhex("".join(hex_values)) | ||
binary_file.write(binary_data) | ||
|
||
yield binary_file_path | ||
|
||
|
@@ -101,9 +101,8 @@ | |
|
||
def test_binary_value_length(): | ||
""" | ||
Creates a binary file from the text packet data, which is more representative | ||
of the actual operational environment. The binary file is deleted after the | ||
test session. | ||
Validates the length of binary data converted | ||
from a text file containing hexadecimal packet data. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This function is sort of recreating what you're already doing in the fixture above. You could just add the assert up there if you're trying to test that file. |
||
""" | ||
packet_path = ( | ||
imap_module_directory | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.