Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add greglucas as a contributor for code, bug, and 5 more #27

Merged
merged 3 commits into from
Jul 12, 2023

Conversation

allcontributors[bot]
Copy link
Contributor

Adds @greglucas as a contributor for code, bug, data, doc, ideas, infra, maintenance.

This was requested by bourque in this comment

[skip ci]

@bourque bourque self-requested a review July 12, 2023 16:32
@bourque bourque self-assigned this Jul 12, 2023
Comment on lines +17 to +18
"bug",
"data",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"bug",
"data",

I haven't contributed any bug fixes or data to this repository. More generally, I'd say we should update this as contributions come in from everyone and not just blanket give everyone on the project the "full" suite of contributions. Thoughts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a fair point, and certainly a way we could go about this. My thinking was to try to just get 'ahead' and get our core-development team all in here with the assumption that we would all be contributing these things eventually. But maybe that is a bad assumption.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 I can see it either way, I personally just like the minimal updates, but understand the bulk add too.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is easy enough to make the change so I went ahead and did that 😄

@bourque bourque merged commit 0747901 into dev Jul 12, 2023
@bourque bourque deleted the all-contributors/add-greglucas branch July 12, 2023 17:00
laspsandoval pushed a commit to laspsandoval/imap_processing that referenced this pull request Nov 15, 2023
…e-Operations-Center/all-contributors/add-greglucas

docs: add greglucas as a contributor for code, bug, and 5 more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants