-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add greglucas as a contributor for code, bug, and 5 more #27
Conversation
"bug", | ||
"data", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"bug", | |
"data", |
I haven't contributed any bug fixes or data to this repository. More generally, I'd say we should update this as contributions come in from everyone and not just blanket give everyone on the project the "full" suite of contributions. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a fair point, and certainly a way we could go about this. My thinking was to try to just get 'ahead' and get our core-development team all in here with the assumption that we would all be contributing these things eventually. But maybe that is a bad assumption.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷 I can see it either way, I personally just like the minimal updates, but understand the bulk add too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is easy enough to make the change so I went ahead and did that 😄
…e-Operations-Center/all-contributors/add-greglucas docs: add greglucas as a contributor for code, bug, and 5 more
Adds @greglucas as a contributor for code, bug, data, doc, ideas, infra, maintenance.
This was requested by bourque in this comment
[skip ci]