CoDICE decompression algorithms for science data #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bourque
added
Ins: CoDICE
bourque
requested review from
sdhoyt,
greglucas,
tech3371,
bryan-harter,
laspsandoval,
GFMoraga and
maxinelasp
and removed request for
a team
bourque
force-pushed
the
codice-decompression
branch
from
571521a to
1682eae
Compare
greglucas
reviewed
Nov 14, 2023
… codice utils folder to store some utils code akin to swe
bourque
force-pushed
the
codice-decompression
branch
from
1682eae to
acb9487
Compare
bourque
force-pushed
the
codice-decompression
branch
from
e6d6407 to
cbfea18
Compare
sdhoyt
approved these changes
Nov 15, 2023
maxinelasp
reviewed
Nov 15, 2023
| decompressed_value : int | ||
| The 24- or 32-bit decompressed value | ||
| """ | ||
| if algorithm == CoDICECompression.NO_COMPRESSION: |
There was a problem hiding this comment.
You could pass a function into this method instead of this if/else table. So, you could pass in _apply_lossy_a as algorithm and then this whole table could just be algorithm(decompress). Not sure if that makes sense for the rest of your code, but it could be an interesting option to reduce the number of functions and get rid of that enum.
https://stackoverflow.com/questions/1349332/python-passing-a-function-into-another-function
maxinelasp
approved these changes
Nov 15, 2023
greglucas
approved these changes
Nov 16, 2023
… codice utils folder to store some utils code akin to swe
bourque
force-pushed
the
codice-decompression
branch
from
cbfea18 to
e8921ab
Compare
…sing into codice-decompression
… assigning compression algorithm
GFMoraga
approved these changes
Nov 20, 2023
laspsandoval
pushed a commit
to laspsandoval/imap_processing
that referenced
this pull request
Apr 2, 2024
…dice-decompression CoDICE decompression algorithms for science data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
This PR implements the six possible CoDICE decompression algorithms for science data, with supporting unit tests. The algorithms are:
This PR closes #249 , however there will likely need to be some tweaks down the line to get this working with the greater CoDICE L0-L1A decom algorithm
New Dependencies
None
New Files
imap_processing/codice/l0/decompress_codice.pyimap_processing/codice/tests/test_decompress_codice.pydecompress_codice.pyDeleted Files
None
Updated Files
imap_processing/codice/l0/__init__.pyTesting
test_decompress_codice.pycontains a unit test for each of the 6 algorithms using an input value of234(I picked this randomly), as well as an attempt to use an unsupported algorithm, which should result in a decompressed value ofNone.