PERF: Speed up bitstring conversions in idex #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglucas
added
Ins: IDEX
bourque
approved these changes
Jan 9, 2024
Bitstring was allocating many new objects which added significant overhead. We can just use Python's native int conversions and indexing into strings to achieve the same result.
greglucas
force-pushed
the
idex-speedups
branch
from
00beca7 to
0fa8bf2
Compare
I was running a lot of tests and didn't understand how we could be so slow... I think there will likely be others here as well, but I've always had my eye on bitstring and cdflib being pure python and slow for our use-cases, so it sort of reaffirmed this to me when running cProfile. |
greglucas
merged commit 64fcb13
into
IMAP-Science-Operations-Center:dev
17 checks passed
laspsandoval
pushed a commit
to laspsandoval/imap_processing
that referenced
this pull request
Apr 2, 2024
…idex-speedups PERF: Speed up bitstring conversions in idex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
Bitstring was allocating many new objects which added significant overhead. We can just use Python's native int conversions and indexing into strings to achieve the same result.
performance script:
python -m cProfile -o orig.prof -m pytest imap_processing/idex/testscurrent version
new version
There are originally over 3M calls to ba2int and over 1M calls to _readlist, versus 228k and 0 in the new version.