TST: Re-use test fixtures within the module if possible #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This speeds things up by not having to read the data so often
greglucas
added
Ins: GLOWS
maxinelasp
approved these changes
Jan 9, 2024
|
Thanks for catching this, I'll keep it in mind for future tests too! |
greglucas
merged commit f2560cf
into
IMAP-Science-Operations-Center:dev
17 checks passed
laspsandoval
pushed a commit
to laspsandoval/imap_processing
that referenced
this pull request
Apr 2, 2024
…tst-glows-fixture TST: Re-use test fixtures within the module if possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
This speeds things up by not having to read the data so often.
Luckily or unluckily GLOWS was the only one that was easy to update and tests still passed. IDEX mutated their read-in data, so had to it has to be re-read each time, and Ultra was using function-level fixtures which can't be increased in scope, but seemingly those could be updated as well.