MNT: Cleanup ruff codes #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bourque
approved these changes
Jan 12, 2024
We can rework the IDEX code to pull out the unchanging variables from the objects and keep that separate.
greglucas
force-pushed
the
ruff-cleanup
branch
from
31d4021 to
1ce6790
Compare
|
I saw that the MAPPING global was actually never used. I turned that into an Enum now in a separate following commit if you wanted to check that at all too. |
|
Looks good! |
greglucas
merged commit d70afd8
into
IMAP-Science-Operations-Center:dev
17 checks passed
laspsandoval
pushed a commit
to laspsandoval/imap_processing
that referenced
this pull request
Apr 2, 2024
…ruff-cleanup MNT: Cleanup ruff codes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
Update the
pyproject.tomlruff flags that we are ignoring.This looks like a large diff, but is largely a reorganization within the IDEX code. There was a large trigger_dict block that was being set in each object, but it was more of a global constant with information. I pulled that outside the scope of the object and index into the NamedTuples later instead. I also updated it so that the "calc_*" functions don't return things now, but rather set the values to the attributes directly, so I changed the name of those to make it clear we are setting things.