Imap cli updates #330
Merged
Imap cli updates #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tech3371
requested review from
a team,
bourque,
sdhoyt,
greglucas,
bryan-harter,
laspsandoval,
bmcclellan-cu and
maxinelasp
and removed request for
a team
greglucas
reviewed
Feb 1, 2024
|
I had worked through all the comments with Greg in-person. |
…roduce cdf files but it's failing at upload
tech3371
force-pushed
the
imap_cli_updates
branch
from
2b2b163 to
0cde759
Compare
greglucas
approved these changes
Feb 2, 2024
greglucas
merged commit 98aeb74
into
IMAP-Science-Operations-Center:dev
17 checks passed
laspsandoval
pushed a commit
to laspsandoval/imap_processing
that referenced
this pull request
Apr 2, 2024
* initial update to add SWE to imap_cli. WIP: It processes to l1a and produce cdf files but it's failing at upload * added SWE l1b to imap_cli. TODO: fix start time issue for l1b * updated to cli and SWE code to work with imap_cli command from batch * added some print statements * added dockerfile in example folder * update to dependency command input * temporary fix for version for demo * path fixes * feedback changes * TST: Update tests for new file date format * TST: Add xfails to swe cdf creation tests temporarily --------- Co-authored-by: Greg Lucas <greg.m.lucas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This is not meant to be merge. I will create issues to address some of the things we need to think about and address post demo. Opening this PR so that you can see what I push to the ECR image that batch job uses.