FIX: Make sure configurations are synced between packages #336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
This moves all the data configuration handling to the
imap_data_access
package.An alternative would be to share the configuration dictionary between the packages by doing something like:
from imap_data_access import config
inimap_processing.__init__.py
but that seems like too much sharing at that point and we should really keep the configuration dictionaries separate and modify the proper ones where appropriate. This means that I removed the configuration dictionary fromimap_processing
now since it only had data storage methods in it.I'm not sure if we can cross-repo close issues, but worth a shot.
closes IMAP-Science-Operations-Center/imap-data-access#15
Deleted Files
Updated Files
imap_data_access.config
instead ofimap_processing.config