Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Make sure configurations are synced between packages #336

Conversation

greglucas
Copy link
Collaborator

Change Summary

Overview

This moves all the data configuration handling to the imap_data_access package.

An alternative would be to share the configuration dictionary between the packages by doing something like:
from imap_data_access import config in imap_processing.__init__.py but that seems like too much sharing at that point and we should really keep the configuration dictionaries separate and modify the proper ones where appropriate. This means that I removed the configuration dictionary from imap_processing now since it only had data storage methods in it.

I'm not sure if we can cross-repo close issues, but worth a shot.
closes IMAP-Science-Operations-Center/imap-data-access#15

Deleted Files

  • test_data_access
    • This is handled in the other repository and that is there already. Not sure there is a great way to test this here?

Updated Files

  • Updates to the global test fixture to set the imap_data_access utilities to a temporary directory.
  • Updates to use imap_data_access.config instead of imap_processing.config

This moves all the data configuration handling to the imap_data_access
package.
@greglucas greglucas added the bug Something isn't working label Feb 13, 2024
@greglucas greglucas requested review from a team, bourque, sdhoyt, tech3371, bryan-harter, laspsandoval, bmcclellan-cu and maxinelasp and removed request for a team February 13, 2024 00:03
Copy link
Collaborator

@bourque bourque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Perhaps for a different PR, but we should also remove the INSTRUMETNS and PROCESSING_LEVELS in the __init__.py file and import those from imap_data_access as well.

Copy link
Contributor

@maxinelasp maxinelasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks good. Hopefully this fixes the weird conflicts!

@greglucas greglucas merged commit 96be9a0 into IMAP-Science-Operations-Center:dev Feb 13, 2024
17 checks passed
@greglucas greglucas deleted the synchronize-data-access branch February 13, 2024 17:53
laspsandoval pushed a commit to laspsandoval/imap_processing that referenced this pull request Apr 2, 2024
…ce-Operations-Center#336)

This moves all the data configuration handling to the imap_data_access
package.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG - Not accessing IMAP_DATA_DIR env var
5 participants