Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L0 Decom Ultra #347

Merged
merged 20 commits into from
Feb 27, 2024
Merged

Conversation

laspsandoval
Copy link
Contributor

@laspsandoval laspsandoval commented Feb 22, 2024

Change Summary

Overview

Added parsing/decompression for additional apids. Combined the XTCEs so that they may be used for all apids.

New Files

  • decom_tools.py
    • Provides decom tools.
  • decom_ultra.py
    • Logic for deciding what algorithm should be applied to what apid.
  • ultra_utils.py
    • Mainly used for apid 896 and 960. There are multiple images in each packet that have to be further parsed after space packet parser.
  • ULTRA_SCI_COMBINED.xml
    • Combination of all xml files.
  • conftest.py
    • New file paths.
  • New test data added

Deleted Files

  • All XTCEs were deleted since we now have one that is combined

Testing

There are 4 test files that represent each Ultra 45 APID:
test_decom_apid_880.py
test_decom_apid_881.py
test_decom_apid_883.py
test_decom_apid_896.py

Ultra 90 will have the same logic as Ultra 45. However, we will add Ultra 90 test data as it becomes available and perform the same tests.

Additionally, more unit tests and error handling will be included in a following PR.

@laspsandoval laspsandoval requested review from greglucas, tech3371, a team, demajistre, d-linko, ndjhu and severian1 and removed request for a team February 22, 2024 21:52
@laspsandoval laspsandoval self-assigned this Feb 22, 2024
@laspsandoval laspsandoval added this to the Decom and L1A Algorithms milestone Feb 22, 2024
@laspsandoval laspsandoval added Ins: Ultra Related to the IMAP-Ultra instrument Level: L0 Level 0 processing labels Feb 22, 2024
@laspsandoval laspsandoval linked an issue Feb 22, 2024 that may be closed by this pull request
imap_processing/tests/ultra/unit/test_decom_apid_880.py Outdated Show resolved Hide resolved
imap_processing/tests/ultra/unit/test_decom_apid_883.py Outdated Show resolved Hide resolved
imap_processing/ultra/l0/decom_tools.py Outdated Show resolved Hide resolved
imap_processing/ultra/l0/decom_tools.py Outdated Show resolved Hide resolved
imap_processing/ultra/l0/decom_tools.py Outdated Show resolved Hide resolved
imap_processing/ultra/l0/decom_ultra.py Outdated Show resolved Hide resolved
imap_processing/ultra/l0/decom_ultra.py Outdated Show resolved Hide resolved
imap_processing/ultra/l0/ultra_utils.py Outdated Show resolved Hide resolved
imap_processing/ultra/l0/ultra_utils.py Outdated Show resolved Hide resolved
imap_processing/ultra/l0/ultra_utils.py Outdated Show resolved Hide resolved
This was linked to issues Feb 23, 2024
Copy link
Contributor

@tech3371 tech3371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring! I had some questions. Besides that it looks good to me.

imap_processing/tests/ultra/unit/conftest.py Show resolved Hide resolved
imap_processing/ultra/l0/ultra_utils.py Outdated Show resolved Hide resolved
imap_processing/ultra/l0/ultra_utils.py Outdated Show resolved Hide resolved
imap_processing/ultra/l0/ultra_utils.py Show resolved Hide resolved
imap_processing/ultra/l0/ultra_utils.py Show resolved Hide resolved
imap_processing/ultra/l0/decom_tools.py Outdated Show resolved Hide resolved
imap_processing/ultra/l0/decom_tools.py Outdated Show resolved Hide resolved
imap_processing/ultra/l0/decom_tools.py Outdated Show resolved Hide resolved
imap_processing/ultra/l0/decom_tools.py Show resolved Hide resolved
imap_processing/ultra/l0/decom_tools.py Show resolved Hide resolved
Copy link
Contributor

@tech3371 tech3371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating documents! I would run this by Bob or Nick offline since I don't details of the algorithm. I will approve this so that this unblocks your CDF work.

@laspsandoval laspsandoval merged commit 1b28a76 into IMAP-Science-Operations-Center:dev Feb 27, 2024
17 checks passed
laspsandoval added a commit to laspsandoval/imap_processing that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ins: Ultra Related to the IMAP-Ultra instrument Level: L0 Level 0 processing
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Validate Ultra L1A data Unpack and process Ultra packets to L1A Create XTCE for all Ultra apids
4 participants