Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create l1a cdfs for auxiliary data packet #352

Merged
merged 8 commits into from
Feb 29, 2024
Merged

Create l1a cdfs for auxiliary data packet #352

merged 8 commits into from
Feb 29, 2024

Conversation

laspsandoval
Copy link
Contributor

@laspsandoval laspsandoval commented Feb 27, 2024 •
edited
Loading

Change Summary

Overview

Creates l1a cdfs for auxiliary packets.

New Files

  • ultra_l1a.py
    • creates xarray and cdc for aux packet
  • ultra_cdf_attrs.py
    • attributes to be added to aux data
  • init.py
    • version information

Updated Files

  • pyproject.toml
    • most recent version of cdflib
  • poetry.lock
    • result of pyproject.toml being updated

Testing

  • test_ultra_l1a.py
    • tests attributes were properly added to the xarray and the xarray contains expected datasets
    • tests that cdf is created and that it contains content from xarray

@laspsandoval laspsandoval self-assigned this Feb 27, 2024
@laspsandoval laspsandoval linked an issue Feb 27, 2024 that may be closed by this pull request
Write Ultra L1A data to CDF file #152
Closed
@laspsandoval laspsandoval added the Ins: Ultra Related to the IMAP-Ultra instrument label Feb 27, 2024
tech3371
tech3371 reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@tech3371 tech3371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor things. Otherwise it looks good. In the future, can you add Bryan to these CDF PR since he knows more about this?

tech3371
tech3371 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@tech3371 tech3371 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tagged concerned people so that they can look at it tests that are failing.

imap_processing/tests/codice/test_codice_l1a.py
@@ -29,6 +29,7 @@ def l0_test_data() -> list:
return packets


@pytest.mark.xfail(reason="Fix for updated cdflib")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bourque

imap_processing/tests/idex/test_l1_cdfs.py
@@ -21,7 +21,7 @@ def decom_test_data():
return PacketParser(test_file)


@pytest.mark.xpass(reason="Need to fix new ISTP error in IDEX CDF")
@pytest.mark.xfail(reason="Need to fix new ISTP error in IDEX CDF")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bourque @bryan-harter

imap_processing/tests/mag/test_mag_decom.py
@@ -59,6 +60,7 @@ def test_mag_raw_xarray():
assert burst_data.dims["Epoch"] == expected_burst_len


@pytest.mark.xfail(reason="Fix for updated cdflib")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxinelasp

@laspsandoval laspsandoval merged commit 719e02b into IMAP-Science-Operations-Center:dev Feb 29, 2024
17 checks passed
laspsandoval added a commit to laspsandoval/imap_processing that referenced this pull request Apr 2, 2024
@laspsandoval
Create l1a cdfs for auxiliary data packet (IMAP-Science-Operations-Ce…
b8094e0 
…nter#352)

* Create l1a cdfs for auxiliary data packet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tech3371 tech3371 tech3371 approved these changes

@demajistre demajistre Awaiting requested review from demajistre

@d-linko d-linko Awaiting requested review from d-linko

@mstrumik mstrumik Awaiting requested review from mstrumik

@ndjhu ndjhu Awaiting requested review from ndjhu

@bryan-harter bryan-harter Awaiting requested review from bryan-harter

Assignees

@laspsandoval laspsandoval

Labels
Ins: Ultra Related to the IMAP-Ultra instrument
Projects
IMAP
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Write Ultra L1A data to CDF file
2 participants
@laspsandoval @tech3371