Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update decom for APID 881 due to changes in packet definitions #353

Merged
merged 7 commits into from
Mar 4, 2024

Conversation

laspsandoval
Copy link
Contributor

Change Summary

Overview

One of the fields "FASTDATA_00" is required to be broken down further. This PR is to add those packet definitions to the decom_data.

New Files

None

Deleted Files

None

Updated Files

imap_processing/ultra/l0/decom_ultra.py

  • added fields to dictionary for apid 881
    imap_processing/ultra/l0/ultra_utils.py
  • added fields for apid 881
  • capitalized fields for apid 896

Testing

imap_processing/tests/ultra/unit/test_decom_apid_881.py

  • modified test to include new fields
    imap_processing/tests/ultra/unit/test_decom_apid_896.py
  • capitalized fields

@laspsandoval laspsandoval self-assigned this Feb 29, 2024
@laspsandoval laspsandoval requested review from tech3371, demajistre, severian1, d-linko, ndjhu and a team and removed request for a team February 29, 2024 16:41
@laspsandoval laspsandoval added the Ins: Ultra Related to the IMAP-Ultra instrument label Feb 29, 2024
@laspsandoval laspsandoval requested review from bryan-harter, greglucas, maxinelasp, bourque and sdhoyt and removed request for greglucas and maxinelasp February 29, 2024 23:38
imap_processing/ultra/l0/decom_ultra.py Outdated Show resolved Hide resolved
imap_processing/ultra/l0/decom_ultra.py Show resolved Hide resolved
@laspsandoval laspsandoval merged commit 1679cfe into IMAP-Science-Operations-Center:dev Mar 4, 2024
17 checks passed
laspsandoval added a commit to laspsandoval/imap_processing that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ins: Ultra Related to the IMAP-Ultra instrument
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants