SWE updates to be compliant with new cdflib releases #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryan-harter
reviewed
Mar 5, 2024
| catdesc="Raw counts from SWE", | ||
| fieldname="Raw counts from SWE", | ||
| label_axis="Raw counts from SWE", | ||
| units="counts", |
There was a problem hiding this comment.
I don't know how much I should be focusing on ISTP stuff at the moment, (my guess is not much?) but for the record I'd probably have:
catdesc="Raw electron counts at 12 energy bins between (xx) and (yy) eV"
fieldname="Raw Electron Counts"
label_axis="Counts"
There was a problem hiding this comment.
Whoops you merged right as I was writing lol
There was a problem hiding this comment.
sorry Bryan! Please add comment and I will open with new changes.
laspsandoval
pushed a commit
to laspsandoval/imap_processing
that referenced
this pull request
Apr 2, 2024
…erations-Center#357) * update cdflib version to 1.2.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
main changes: