Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated naming and data product versioning conventions #358

Conversation

bourque
Copy link
Collaborator

@bourque bourque commented Mar 7, 2024

Change Summary

Overview

This PR updates the documents for filenaming and data product versioning conventions based on the conversations during the SDWG meeting on 03/07/2024.

Updated Files

  • docs/source/development-guide/style-guide/naming-conventions.rst
    • Updated filenaming conventions
  • docs/source/development-guide/style-guide/versioning.rst
    • Update data product versioning conventions

@bourque bourque added the Repo: Documentation Improvements or additions to documentation label Mar 7, 2024
@bourque bourque self-assigned this Mar 7, 2024
Copy link
Collaborator

@greglucas greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits, otherwise I think it agrees with what we discussed. Thanks for updating this!

* HIT: TBD
* IDEX: TBD
* IMAP-Hi: TBD
* IMAP-Hi: ``45sensor-counts``, ``90sensor-counts``, ``45sensor-flux-3month-map`` (more TBD)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to bring this up on the call today, but for consistency should we put 3month at the end?
flux-map-3month similar to how SWAPI has sci-1min with the frequency last.
cc @tech3371

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is probably a good idea!

is also ``YYYYMMDD``.
* ``<version>`` stores the version of the data product in the format is ``vXX-YY``. See the versioning conventions
described in the :ref:`data product versioning <Data Product Versioning>` documentation for further details.
* ``<repointing>`` is an optional component that describes the repointing number, in the format of ``repoint-<num>``,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably want to remove the "-" between repoint and number so it is a single repoint field and the hyphen separates the date and repointing fields.

Suggested change
* ``<repointing>`` is an optional component that describes the repointing number, in the format of ``repoint-<num>``,
* ``<repointing>`` is an optional component that describes the repointing number, in the format of ``repoint<num>``,

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, good catch.

@bourque bourque merged commit 7af0606 into IMAP-Science-Operations-Center:dev Mar 8, 2024
17 checks passed
@bourque bourque deleted the update-naming-and-version-conventions branch March 8, 2024 21:43
laspsandoval pushed a commit to laspsandoval/imap_processing that referenced this pull request Apr 2, 2024
…date-naming-and-version-conventions

Updated naming and data product versioning conventions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Repo: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants