MNT: Use module-level logger #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglucas
requested review from
a team,
bourque,
sdhoyt,
tech3371,
laspsandoval and
maxinelasp
and removed request for
a team
Rather than using the global logger and updating the configuration globally, we should get a logger instance for each module that wants it and submit log messages to that specific logger.
greglucas
force-pushed
the
logger-updates
branch
from
275d094 to
35e65a3
Compare
greglucas
merged commit b006adf
into
IMAP-Science-Operations-Center:dev
15 of 17 checks passed
laspsandoval
pushed a commit
to laspsandoval/imap_processing
that referenced
this pull request
Apr 2, 2024
…logger-updates MNT: Use module-level logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using the global logger and updating the configuration globally, we should get a logger instance for each module that wants it and submit log messages to that specific logger.