-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Update file naming convention via imap-data-access upgrade #363
MNT: Update file naming convention via imap-data-access upgrade #363
Conversation
Also note that I have just set all descriptors to "sci" for now. I'm not sure whether we are setting those in the CDF somewhere, or if we want to just set the CDF metadata attributes with that information directly. This is because the |
ee0783c
to
048b29a
Compare
Bumps imap-data-access to v0.5.0 where there is a new filename requirement on the mission.
048b29a
to
28a8a91
Compare
Some notes/thoughts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple minor comments. Otherwise, it looks good to me!
@@ -154,7 +150,7 @@ def _validate_args(args): | |||
if args.instrument not in imap_data_access.VALID_INSTRUMENTS: | |||
raise ValueError( | |||
f"{args.instrument} is not in the supported instrument list: " | |||
f"{imap_processing.INSTRUMENTS}" | |||
f"{imap_data_access.VALID_INSTRUMENTS}" | |||
) | |||
if args.data_level not in imap_processing.PROCESSING_LEVELS[args.instrument]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we also use valid data level from imap-data-access
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at this, and the VALID_PROCESSING_LEVELS is generic over in that repository and not "per instrument" like we are checking here. So I held off on that for now.
I agree though, we should look at making that update, but I think we should push it off to a follow-up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that sounds good!
Looks great. Thank you so much for doing this! |
OK, I just pushed up one more commit with a bunch of TODOs that will hopefully help everyone with what the previous naming of the file/descriptor was to know what to go back to once we update the global attributes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! And thanks for making the changes for IDEX and CoDICE!
c933ee3
into
IMAP-Science-Operations-Center:dev
…filename-update MNT: Update file naming convention via imap-data-access upgrade
Change Summary
Overview
Bumps imap-data-access to v0.5.0 where there is a new filename requirement on the mission.
This is a major update to the filename convention, so there are lots of areas touched in this PR. Most are just updating the filenaming, but there is one other major update to the
write_cdf()
routine.write_cdf()
was changed to get all of its filename information from the attributes of the passed-in dataset directly, and uses ScienceFilePath fromimap-data-access
. There is an optionaldirectory
argument if you do want to write that dataset somewhere else, but I think this makes it a bit cleaner without requiring every instrument to create their filenames, but instead focus on the metadata, and then you get the filename for free.New Dependencies
imap-data-access>=0.5