MNT: Remove directory option from write_cdf #379
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
We are now explicitly requiring a directory structure for the science files to be written to. A user should update the
imap_data_access.config["DATA_DIR"]
location if they want to write to a different location because theScienceFilePath
uses that field to construct the path.Note that previously
directory
was not working how we were expecting because of theScienceFilePath.construct_path()
usage, so this doesn't change behavior, just removes code that didn't do what it was supposed to.