Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT: Remove directory option from write_cdf #379

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

greglucas
Copy link
Collaborator

Change Summary

Overview

We are now explicitly requiring a directory structure for the science files to be written to. A user should update the imap_data_access.config["DATA_DIR"] location if they want to write to a different location because the ScienceFilePath uses that field to construct the path.

Note that previously directory was not working how we were expecting because of the ScienceFilePath.construct_path() usage, so this doesn't change behavior, just removes code that didn't do what it was supposed to.

We are now explicitly requiring a directory structure for the
science files to be written to. A user should update the
imap_data_access.config["DATA_DIR"] location if they want to write
to a different location because the ScienceFilePath uses that
field to construct the path.
@greglucas greglucas requested review from a team, bourque, sdhoyt, tech3371, vmartinez-cu, laspsandoval and maxinelasp and removed request for a team March 28, 2024 15:02
Copy link
Contributor

@maxinelasp maxinelasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@greglucas greglucas merged commit 021ea9a into IMAP-Science-Operations-Center:dev Apr 2, 2024
17 checks passed
@greglucas greglucas deleted the write_cdf branch April 2, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants